Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display: avoid using formatter #36

Merged
merged 1 commit into from Oct 27, 2019
Merged

display: avoid using formatter #36

merged 1 commit into from Oct 27, 2019

Conversation

mathstuf
Copy link
Contributor

This can collide with enum variant field names. Namespace with a
_thiserror_ prefix to avoid such collisions.

@mathstuf
display: avoid using formatter
5ae5b4e 
This can collide with enum variant field names. Namespace with a
`_thiserror_` prefix to avoid such collisions.
dtolnay
dtolnay approved these changes Oct 27, 2019
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 5ae5b4e into dtolnay:master Oct 27, 2019
@dtolnay
Copy link
Owner

dtolnay commented Oct 27, 2019

Published in thiserror 1.0.4.

@mathstuf mathstuf deleted the formatter-name-collision branch October 27, 2019 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mathstuf @dtolnay