Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 2.1.2 version is fails the audit #23

Closed
hadaabhi201 opened this issue Mar 18, 2020 · 4 comments
Closed

The 2.1.2 version is fails the audit #23

hadaabhi201 opened this issue Mar 18, 2020 · 4 comments

Comments

@hadaabhi201
Copy link

hadaabhi201 commented Mar 18, 2020

Repro Steps:
Node version:v12.12.0

$ npm init -y

$ npm install --save chromium

chromium@2.1.2 postinstall /Users/abhishekhada/Code/src/local/test-audit/node_modules/chromium
node install.js

Step 1. Retrieving Chromium latest revision number
Step 2. Downloading Chromium (this might take a while). Revision number: 751348
Step 3. Setting up Chromium binaries
Process is successfully finished
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN test-audit@1.0.0 No description
npm WARN test-audit@1.0.0 No repository field.

  • chromium@2.1.2
    added 45 packages from 23 contributors and audited 48 packages in 12.252s
    found 1 moderate severity vulnerability
    run npm audit fix to fix them, or npm audit for details

Expected:

  • install the chromium without any vulnerability issue.

Actual

  • Audit failed.
@dtolstyi
Copy link
Owner

Hi @hadaabhi201,

I think these issues with audit has always been here as far as we haven't changed versions of packages for quite some time.
I'm trying to fix it but I'm having issues with latest version of ava. Somehow, it doesn't work fine for me.

If you are able to provide Pull Request with packages updates it would be great.

@hadaabhi201
Copy link
Author

hadaabhi201 commented Mar 18, 2020

@dtolstyi ,

Same here, I am getting issue with ava too. The issue is with mkdrip. Once the issue is fixed on that package will update the package. There is already a MR for the issue:
max-mapper/extract-zip#85
Issue: max-mapper/extract-zip#86

@dtolstyi
Copy link
Owner

dtolstyi commented Mar 18, 2020

Ha, so it's not the problem with my OS. I'm having the same issue. Funny.
I've tried creating .cache folder manually but then it says: Error: folder already exists. Very frustrating))

OK, let's wait for the issue to be solved.

@dtolstyi
Copy link
Owner

All issues are fixed in version 2.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants