Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable native-tls in release #169

Open
Yamakaky opened this issue Aug 18, 2021 · 4 comments
Open

Enable native-tls in release #169

Yamakaky opened this issue Aug 18, 2021 · 4 comments

Comments

@Yamakaky
Copy link

Currently, binaries are built with the default features, which doesn't include native-tls. It would be nice to have it enabled.

@blyxxyz
Copy link
Collaborator

blyxxyz commented Aug 18, 2021

native-tls is enabled in the Windows and macOS builds.

It's not enabled in the Linux builds because it would use dynamic linking, so you wouldn't be able to run the binary everywhere. The current binary is fully statically linked.

You can get a binary with native-tls on Linux by running cargo install xh --features native-tls. (You might need to install libssl-dev and pkg-config to get it to build, depending on your distro.)

But maybe third-party packages should be built with it, they can make more assumptions.

@Yamakaky
Copy link
Author

Hum, OK, unlucky. Maybe document this somewhere?

@svenstaro
Copy link

Just for the record: The Arch package is built with native-tls and I suppose any other distro's packages should also be built with that option so it's really not that big of an issue on Linux and I agree with upstream's decision here to keep the pre-built binary entirely static.

@jirutka
Copy link
Contributor

jirutka commented Sep 26, 2022

BTW, if you like to provide statically linked binaries linked against OpenSSL 3, it can be easily done using GitHub Action jirutka/setup-alpine, see this example in the readme. That said I don’t think it’s a good idea to bundle OpenSSL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants