Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for UHUGEINT (u128) in FromSql trait #273

Open
nmlt opened this issue Mar 7, 2024 · 2 comments
Open

No support for UHUGEINT (u128) in FromSql trait #273

nmlt opened this issue Mar 7, 2024 · 2 comments

Comments

@nmlt
Copy link

nmlt commented Mar 7, 2024

It seems like support for u128 was forgotten, as u64 and i128 are supported. Is the fix as easy as adding from_sql_integral!(u128); to this file?

Edit: It's also missing for the ToSql trait.

I fixed it by following the compiler advice, but now I'll first check whether it actually works in my project. Then I'll submit a pull request.

@nmlt
Copy link
Author

nmlt commented Mar 7, 2024

Hmm, looks like UHUGEINT was just added?

Anyway I'm getting a runtime crash with my code when it callsffi::duckdb_bind_uhugeint.

@Mause
Copy link
Member

Mause commented Apr 3, 2024

Unfortunately UHugeInt isn't yet supported in the arrow layer in DuckDB, but binding support would be good to have in the interim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants