Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1127: Fixed the z-index of the widget replacement button. #1292

Closed
wants to merge 1 commit into from
Closed

Fixes #1127: Fixed the z-index of the widget replacement button. #1292

wants to merge 1 commit into from

Conversation

mighty-phoenix
Copy link

@mighty-phoenix mighty-phoenix commented Jul 18, 2022 •
edited

Reviewer: @colinje @kzar @jonathanKingston

Description:

Fixes #1127: Fixed the z-index of the widget replacement button.

Steps to test this PR:

  1. Navigate to https://downdetector.com/
  2. Scroll down until the position of the "Unblock" button of replacement widget is in the same space as the top nav

Impact

Screen.Recording.2022-07-31.at.4.26.50.AM.mov

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

colinje
colinje approved these changes Jul 19, 2022
View reviewed changes
Copy link

@colinje colinje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mighty-phoenix
Copy link
Author

Thanks for the review! @colinje

@sammacbeth sammacbeth closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinje colinje colinje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Widget Replacement button too high on z-axis
3 participants
@mighty-phoenix @colinje @sammacbeth