Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix native addons #425

Closed
n1ru4l opened this issue May 10, 2020 · 0 comments · Fixed by #427
Closed

fix native addons #425

n1ru4l opened this issue May 10, 2020 · 0 comments · Fixed by #427
Labels
bug

Comments

@n1ru4l
Copy link
Member

n1ru4l commented May 10, 2020 •
edited

The executable for 1.7.1 and 1.7.0 are currently broken. I will unpublish the releases for now until we resolved this issue.

The zip folder structure must be the following (example osx):

- dungeon-revealer-macos
- node_sqlite3.node
- README.md
- LICENSE

Until vercel/pkg#837 is resolved we must store node_sqlite3.node alongside the binary.

For now we probably need to move them from node_modules/sqlite3/lib/binding/node-{node-version}-{platform}-{architecture}/node_sqlite3.node

I think we must also add a License and copyright notice for sqlite3 as it used the BSD 3 License.
@n1ru4l n1ru4l added the bug label May 10, 2020
@n1ru4l n1ru4l mentioned this issue May 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: binaries n1ru4l/dungeon-revealer
1 participant
@n1ru4l