Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests when mockk supports inline classes #46

Closed
GregHib opened this issue Mar 30, 2020 · 2 comments
Closed

Fix tests when mockk supports inline classes #46

GregHib opened this issue Mar 30, 2020 · 2 comments
Assignees
@GregHib
Labels
bug Something isn't working

Comments

@GregHib
Copy link
Contributor

GregHib commented Mar 30, 2020 •
edited

Using inline classes is blocked by mockk/mockk#152.
Current tests affected:

  • EventBusTest.kt
  • EntityListTest.kt
  • ViewportTest.kt
  • PreUpdateCalculationTaskTest.kt
@GregHib GregHib added the bug Something isn't working label Mar 30, 2020
@GregHib GregHib self-assigned this Mar 30, 2020
@GregHib
Copy link
Contributor Author

GregHib commented Mar 30, 2020 •
edited

Temporary solution to replace inline with data classes.

Current classes temporarily using data:
* Tile

@GregHib GregHib changed the title Fix inline class tests Add Inline classes once mockk fixed Mar 30, 2020
GregHib added a commit that referenced this issue Apr 3, 2020
@GregHib
Switched entities to data classes removing TileSystem.kts and switchi…
8aeb6e0 
…ng back to inline classes fixing #46
GregHib added a commit that referenced this issue Apr 4, 2020
@GregHib
Switched entities to data classes removing TileSystem.kts closes #18
b592ec4 
Switched Tile to an inline class closing #46
GregHib added a commit that referenced this issue Apr 4, 2020
@GregHib
Switched entities to data classes removing TileSystem.kts closes #18
799a87f 
Switched Tile to an inline class closing #46
@GregHib GregHib added this to To do in Engine via automation Apr 4, 2020
@GregHib GregHib closed this as completed Apr 4, 2020
Engine automation moved this from To do to Done Apr 4, 2020
kiairatech pushed a commit that referenced this issue Apr 9, 2020
@GregHib @kiairatech
Switched entities to data classes removing TileSystem.kts closes #18
4a06c43 
Switched Tile to an inline class closing #46
GregHib added a commit that referenced this issue Apr 11, 2020
@GregHib
Switched entities to data classes removing TileSystem.kts closes #18
476d846 
Switched Tile to an inline class closing #46
GregHib added a commit that referenced this issue Apr 12, 2020
@GregHib
Switched entities to data classes removing TileSystem.kts closes #18
3c95b29 
Switched Tile to an inline class closing #46
GregHib added a commit that referenced this issue Apr 13, 2020
@GregHib
Switched entities to data classes removing TileSystem.kts closes #18
dcb76bf 
Switched Tile to an inline class closing #46
@GregHib GregHib changed the title Add Inline classes once mockk fixed Fix tests when mockk supports inline classes Apr 22, 2020
@GregHib GregHib reopened this Apr 22, 2020
Engine automation moved this from Done to In progress Apr 22, 2020
@GregHib GregHib removed this from In progress in Engine Apr 23, 2020
@GregHib GregHib closed this as completed in cba00b9 May 3, 2020
GregHib added a commit that referenced this issue May 3, 2020
@GregHib
Removed inline classes closes #46
7c5220e
@GregHib
Copy link
Contributor Author

GregHib commented May 3, 2020

Removed inline class usage, storing the coordiantes as one id didn't allow for negative values needed for simplified delta movement.

GregHib added a commit that referenced this issue May 3, 2020
@GregHib
Removed inline classes closes #46
6ff39b8
GregHib added a commit that referenced this issue May 4, 2020
@GregHib
Removed inline classes closes #46
8c2c1fb
GregHib added a commit that referenced this issue May 4, 2020
@GregHib
Removed inline classes closes #46
b3cbcf5
GregHib added a commit that referenced this issue May 5, 2020
@GregHib
Removed inline classes closes #46
7b29a5b
GregHib added a commit that referenced this issue May 8, 2020
@GregHib
Removed inline classes closes #46
8b622a7
GregHib added a commit that referenced this issue May 12, 2020
@GregHib
Removed inline classes closes #46
996a7d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GregHib GregHib

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GregHib