Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium OS/Chrome OS is missing from OS map list #209

Open
sharoncraddock opened this issue Feb 15, 2023 · 0 comments
Open

Chromium OS/Chrome OS is missing from OS map list #209

sharoncraddock opened this issue Feb 15, 2023 · 0 comments

Comments

@sharoncraddock
Copy link

sharoncraddock commented Feb 15, 2023

  1. I'd like to be able to detect Chromebook users - web says the OS is called Chrome OS, but using/inspecting your deviceDetect method I get "'Chromium OS" for the osName:
deviceDetect object {"isBrowser":true,"browserMajorVersion":"108","browserFullVersion":"108.0.0.0","browserName":"Chrome","engineName":"Blink","engineVersion":"108.0.0.0","osName":"Chromium OS","osVersion":"15183.78.0","userAgent":"Mozilla/5.0 (X11; CrOS x86_64 15183.78.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/[108.0.0.0](http://108.0.0.0/) Safari/537.36"}
  1. Add Chromium OS (and/or Chrome OS) to the list of OS types in https://github.com/duskload/react-device-detect/blob/master/src/constants/typesMaps.js

  2. I'd like to have the osName method return 'Chromium OS' when the OS is Chromium OS.

@sharoncraddock sharoncraddock changed the title Chrome OS is missing from OS map list Chromium OS/Chrome OS is missing from OS map list Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant