New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publicUrl method check looks for wrong exception. #1445

Open

wizhippo opened this issue Apr 22, 2024 · 0 comments

wizhippo commented Apr 22, 2024 •

edited

https://github.com/dustin10/VichUploaderBundle/blame/ec9ad4b732c0d9063e6bf0221bb758ac405d64a2/src/Storage/FlysystemStorage.php#L123

This is catching the wrong exception.

It is throwing Symfony\Component\ErrorHandler\Error\UndefinedMethodError not FilesystemException

Seems this method is on Flysystem 3.6 onward.
My deps currently use 2.x

To support 2.x should allow either exception?

Related to but not the same isuse: #1444

wizhippo added a commit to wizhippo/VichUploaderBundle that referenced this issue


          Fix issue 1445

e89dfcf

dustin10#1445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment