Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on PingFoundation dealloc #138

Open
ohlulu opened this issue Oct 11, 2022 · 2 comments · May be fixed by #139
Open

Crash on PingFoundation dealloc #138

ohlulu opened this issue Oct 11, 2022 · 2 comments · May be fixed by #139

Comments

@ohlulu
Copy link

ohlulu commented Oct 11, 2022 •
edited

根據文檔，或許我們不應該在 PingFoundation dealloc 時調用 [self stop] ？

Crash call stack:

Crashed: SearchSerialQueue (QOS: UNSPECIFIED)
0  CFNetwork                      0xca530 CFHostUnscheduleFromRunLoop + 60
1  RealReachability               0xa230 -[PingFoundation stopHostResolution] + 800 (PingFoundation.m:800)
2  RealReachability               0xa2d0 -[PingFoundation stop] + 816 (PingFoundation.m:816)
3  RealReachability               0x8d0c -[PingFoundation dealloc] + 188 (PingFoundation.m:188)
4  RealReachability               0xa990 -[PingHelper setHost:] + 116 (PingHelper.m:116)

...
@ohlulu ohlulu linked a pull request Oct 12, 2022 that will close this issue
Open
@xiaoshaogg
Copy link

xiaoshaogg commented Nov 8, 2022 •
edited

在iOS16上会崩溃，和robbiehanson/CocoaAsyncSocket#803 这个类似

@ohlulu
Copy link
Author

ohlulu commented Nov 15, 2022 •
edited

@xiaoshaogg
請問是指 #139 這個 PR 會在 iOS16 上崩潰嗎？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: doesn't call self method on dealloc ohlulu/RealReachability
2 participants
@xiaoshaogg @ohlulu