Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Electron to Latest Version #153

Closed
stamoun opened this issue Sep 16, 2021 · 1 comment
Closed

Update Electron to Latest Version #153

stamoun opened this issue Sep 16, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@stamoun
Copy link
Collaborator

stamoun commented Sep 16, 2021

Electron offers a lot of QoL improvments, we should update to the latest version.

@stamoun stamoun created this issue from a note in v2.0.0 (On hold) Sep 16, 2021
@stamoun stamoun added this to High priority in Bugs Sep 16, 2021
@stamoun stamoun added the enhancement New feature or request label Feb 26, 2022
@stamoun stamoun self-assigned this Feb 28, 2022
@stamoun stamoun moved this from On hold to In progress in v2.0.0 Feb 28, 2022
@stamoun stamoun changed the title Update Electron to 14.0.0 (on hold: releasing 1.6.0 first) Update Electron to Latest Version Feb 28, 2022
@stamoun
Copy link
Collaborator Author

stamoun commented Mar 16, 2022

Todo:

  • Config loading on first lunch is borked
  • Liked track transfers when a new track starts

Non-blocking issues to create:

Done:

  • Fix full screen vis
  • Retest hardware acceleration on Linux
  • Add husky pre-push lint check
  • Test freemium vs premium
  • fix linter errors
  • Notifications
  • get rid of node-sass...?
  • Fix display volume change
  • Truncate weird song names (remove everything past - or (...)
  • Update vulnerabilities (open PRs)
  • Fix Spotify not detected screen
  • Fix settings window
  • Retest container size on Mac (and remove if necessary)
  • Remove all default exports - Won't do, default exports on files that only have 1 export
  • Proper store.set serialization (seems to not be liking partial stuff)
  • Cleanup shuffle code (no longer used/maintained)
  • Reload default settings from the settings window
  • Remove useless console.log
  • Handle invalid config.json loading
  • Fix or remove hide when spotify not detected, it's broken - Removed for now
  • Change functions to arrow functions - ongoing I change them when I see them
  • Remove the store from everywhere but main/lofi
  • Add extensions.json to .vscode - not needed for now

@stamoun stamoun pinned this issue Jun 27, 2022
@stamoun stamoun moved this from High priority to To close next release in Bugs Jan 3, 2023
@stamoun stamoun moved this from In progress to Done in v2.0.0 Apr 22, 2023
@stamoun stamoun closed this as completed Apr 24, 2023
Bugs automation moved this from To close next release to Closed Apr 24, 2023
@stamoun stamoun unpinned this issue Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Bugs
Closed
Development

No branches or pull requests

1 participant