fix: Handle systems without IPv6 properly #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 90.50% 91.80% +1.30%
==========================================
Files 9 9
Lines 179 183 +4
==========================================
+ Hits 162 168 +6
+ Misses 17 15 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This looks great @danez merging and releasing now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes IPv6 again.
On systems that have the IPv6 stack disabled (for example ubuntu) the name resolution won't even work for IPv6 and
ENOTFOUNDthrows.This PR adds code that handles this case and also disables IPv6.
netlify/cli#5166
I also added some generic error handling for IPv6 on unexpected errors. So if an unexpected error happens while we are using IPv6 we simply ignore the error and disable IPv6.
I tried to come up with some tests but this is really hard to test. I have an idea though, by disabling IPv6 in the github actions image, but I will do that separatly.