Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.0.0 resolved path issue #403

Closed
aannoune opened this issue May 14, 2024 · 4 comments · Fixed by #404
Closed

v6.0.0 resolved path issue #403

aannoune opened this issue May 14, 2024 · 4 comments · Fixed by #404
Assignees
Labels
feedback Feedback from people using the App or any other repo question A question needs to be answered before progress can be made on this issue T25m Time Estimate 25 Minutes technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@aannoune
Copy link

aannoune commented May 14, 2024

Hello, thanks for the work you are doing.
I'm having an issue with version 6.0.0
the main and types in you package.json is referring to the dist directory witch is dot delivered in the package:
package.json:

{
  "name": "aws-sdk-mock",
  "version": "6.0.0",
  "description": "Functions to mock the JavaScript aws-sdk",
  "type": "module",
  "main": "src/index.js",
  "types": "src/index.d.ts",
  "scripts": {
    "lint": "tsc",
    "nocov": "ts-mocha test/**/*.spec.ts",
    "test": "nyc ts-mocha test/**/*.spec.ts && tsd",
    "coverage": "nyc --report html ts-mocha test/**/*.spec.ts && open coverage/index.html",
    "build": "tsup src/index.ts --format cjs, esm, --dts"
  }

package content :

aws-sdk-mock/
├── CONTRIBUTING.md
├── LICENSE
├── README.md
├── node_modules
│   ├── @sinonjs
│   └── sinon
├── package.json
├── src
│   ├── index.ts
│   └── types.ts
├── test
│   └── index.spec.ts
└── tsconfig.json

this result in a
resoled path issue.

@nelsonic nelsonic added question A question needs to be answered before progress can be made on this issue T25m Time Estimate 25 Minutes technical A technical issue that requires understanding of the code, infrastructure or dependencies feedback Feedback from people using the App or any other repo labels May 14, 2024
@LuchoTurtle
Copy link
Member

Hey @aannounex, thanks for opening an issue 😎

I wager that fixing this problem might be as simple as just using the relative path, like index.d.ts instead of using src.

I'm travelling right now but I'll take a look at it as soon as I can. ☺️

@LuchoTurtle
Copy link
Member

LuchoTurtle commented May 16, 2024

Following the advice from https://mikeesto.com/posts/publishing-npm-package/ and https://cameronnokes.com/blog/the-30-second-guide-to-publishing-a-typescript-package-to-npm/, I think I've found the problem. I've tested using npm pack to create a tarball to see how the files are bundled before publishing to npm and I've already committed some changes on a separate branch.

My internet here is funky and really slow, so it's hard to push branch. I'll try to get it pushed tomorrow (or whenever I have a stable internet connection NOT on my phone :P)

@LuchoTurtle
Copy link
Member

@aannoune we've published 6.0.1 and it should work now. Let us know if it's working now :D

@aannoune
Copy link
Author

Thanks a lot for the work done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback Feedback from people using the App or any other repo question A question needs to be answered before progress can be made on this issue T25m Time Estimate 25 Minutes technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants