Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023 Rebuild? #77

Open
nelsonic opened this issue Feb 11, 2023 · 2 comments
Open

2023 Rebuild? #77

nelsonic opened this issue Feb 11, 2023 · 2 comments

Comments

@nelsonic
Copy link
Member

As noted a couple of years back: dwyl/contact#8 swoosh already had all the features we needed for basic email sending. What it lacked was deliverability tracking. Which was why I didn't use it at the time.
But now that swoosh is included by default in Phoenix 1.6.x it's the "defacto".

That is simultaneously an annoying thing - because there's lots of @dependabot noise https://github.com/search?q=org%3Adwyl+swoosh&type=issues ... - and a really good thing because the decision is made. ✅

So the question is: should email be separate from auth?
Or are we fragmenting our backend too much by making them separate apps? 🤷‍♂️

My original reasoning for making the auth and email apps separate
was so that anyone working on auth didn't have to think about email.
But ... given that swoosh is included in Phoenix by default
(i.e. you have to manually exclude it with --no-email flag)
what is the advantage to keeping them separate? 💭

@iteles
Copy link
Member

iteles commented Feb 11, 2023

The only advantage I can see is to use email for other purposes other than auth.
But for us, I don't think it makes sense - we're adding unnecessary complexity (from a layman's perspective) at this stage.

@nelsonic
Copy link
Member Author

@iteles thanks for your feedback. 🙏
My only reluctance with this is: more setup time for auth. ⏳
But I think I've got a solution. 💡 dwyl/auth#271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants