Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review with "Beginner's Mind" #22 #23

Open
ghost opened this issue May 18, 2017 · 6 comments
Open

Review with "Beginner's Mind" #22 #23

ghost opened this issue May 18, 2017 · 6 comments

Comments

@ghost
Copy link

ghost commented May 18, 2017

"@edwardcodes please can you read through the instructions in this tutorial, try the examples and open any issues when anything is unclear? (thanks!)"

@nelsonic i´ve read through the instructions in this (awesome) tutorial (_the reasons to learn elm are very clear and very captivating) and tried the examples (explaining why the code is there and the meaning with the step-by-step comments is MEGA useful 🥇) but there´s a few things i didn't understand:

"9.1 Tests for Resetting the Counter (Update)"
"9.4 Write View (UI) Tests"

I didn't´t understand were do i put/write the tests in the script.. besides that everything is clear, each function (mount, signal, update, empty, button and view) has their own purpose in the app, we should use "pure" functions so we can have more control of the outputs (the "impure" js can be tricky).

@nelsonic
Copy link
Member

nelsonic commented May 20, 2017

@edwardcodes this is very helpful feedback! (thanks)
image
Does indeed not specify where someone should write the tests.
It's implied in the previous section, but we should be specific to make it clearer for beginners.
https://github.com/dwyl/learn-elm-architecture-in-javascript/tree/09e7bf6d85e5dbee51f7fce0ec6428d4eb60a15e

Did you personally understand where the test was meant to go?
Were you able to complete the exercise despite the lack of clear instruction as to exactly where the test and corresponding code should go?

@ghost
Copy link
Author

ghost commented May 20, 2017

@nelsonic Thank you! Yes i was able to complete the exercise by adding those 3 lines of code in the gif.image (var Res = 'reset';_ case Res: return 0; _button('Reset', signal, Res)) although i understood where the tests should be (update function) i still have doubts as to "where the test and corresponding code should go?" as to where to place them..
https://github.com/dwyl/learn-tdd

@nelsonic
Copy link
Member

@edwardcodes after completing the learn-tdd tutorial was it clearer where the tests should go?

@ghost
Copy link
Author

ghost commented May 21, 2017

@nelsonic i´m still doing the learn-tdd but yes !

@nelsonic
Copy link
Member

@edwardcodes were you able to finish learn-tdd?
(as usual please ask questions if/when you get stuck! thanks!)

@ghost
Copy link
Author

ghost commented May 24, 2017

@nelsonic I wasn't but I'm going to open an issue with the questions i have!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant