Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog doesn't read repo URL from package.json #35

Open
ffxsam opened this issue Jun 29, 2017 · 3 comments
Open

changelog doesn't read repo URL from package.json #35

ffxsam opened this issue Jun 29, 2017 · 3 comments

Comments

@ffxsam
Copy link

ffxsam commented Jun 29, 2017

I have this in package.json:

  "repository": {
    "type": "git",
    "url": "git+https://github.com/abc/xyz.git"
  },

And yet when I run changelog in the project dir, I get:

changelog The module's owner did not specify the repository url in the package.json for proj. You should let the author know.

If I type out the full URL, it works fine:

$ changelog https://github.com/abc/xyz
@rarkins
Copy link
Collaborator

rarkins commented Jun 30, 2017

I think it's the git+https prefix that is causing it. Could you test with only one of them? If so then that will narrow down the problem.

@ffxsam
Copy link
Author

ffxsam commented Jun 30, 2017

I tried just https:// and got the same result.

@GerHobbelt
Copy link
Contributor

changelog only fetches the project name (for querying npm) from the local package.json. The github url is then obtained from the data provided by the npm registry.

If you want package.json to also provide/take-priority-over-npm-registry re github url, see fork commit SHA-1: 67f8877 + SHA-1: 1fdb12a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants