Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm test: unit tests fail for github&npm #43

Open
GerHobbelt opened this issue Oct 3, 2017 · 3 comments
Open

npm test: unit tests fail for github&npm #43

GerHobbelt opened this issue Oct 3, 2017 · 3 comments

Comments

@GerHobbelt
Copy link
Contributor

These fail:


  github
    1) should have something come back for changelog
    2) should have something come back for commit messages

  npm
    3) should have something come back for pageHistory
@rarkins
Copy link
Collaborator

rarkins commented Oct 4, 2017

Don't these pass on Travis though? e.g. in your recent PRs, I click through to Travis results and see:

image

@GerHobbelt
Copy link
Contributor Author

hmmmmm. It broke on the local box, so that must a local issue then? drat!

See https://travis-ci.org/GerHobbelt/changelog/jobs/283166205: changelog b0rks on Node 6 and above.

Will do a quick pullreq for travisci too, so you can see it happen.

GerHobbelt added a commit to GerHobbelt/changelog that referenced this issue Oct 4, 2017
@GerHobbelt
Copy link
Contributor Author

Found where it goes haywire. See commit referenced above.

output:

  github
    1) should have something come back for changelog
    2) should have something come back for commit messages

  npm
    3) should have something come back for pageHistory

  npm
    √ should return everything with no filter
    √ should return everything with filter all
    √ should return latest with filter latest
    √ should return matching single one with semver filter
    √ should return matching several with semver filter


  5 passing (83ms)
  3 pending
  3 failing

  1) github
       should have something come back for changelog:
     Uncaught Error: Invalid Chai property: object
    at Object.proxyGetter [as get] (node_modules\chai\lib\chai\utils\proxify.js:66:17)
    at test\github.test.js:15:37
    at _fulfilled (node_modules\q\q.js:834:54)
    at self.promiseDispatch.done (node_modules\q\q.js:863:30)
    at Promise.promise.promiseDispatch (node_modules\q\q.js:796:13)
    at node_modules\q\q.js:604:44
    at runSingle (node_modules\q\q.js:137:13)
    at flush (node_modules\q\q.js:125:13)
    at _combinedTickCallback (internal/process/next_tick.js:95:7)
    at process._tickDomainCallback (internal/process/next_tick.js:198:9)


  2) github
       should have something come back for commit messages:
     Uncaught Error: Invalid Chai property: object
    at Object.proxyGetter [as get] (node_modules\chai\lib\chai\utils\proxify.js:66:17)
    at test\github.test.js:23:37
    at _fulfilled (node_modules\q\q.js:834:54)
    at self.promiseDispatch.done (node_modules\q\q.js:863:30)
    at Promise.promise.promiseDispatch (node_modules\q\q.js:796:13)
    at node_modules\q\q.js:556:49
    at runSingle (node_modules\q\q.js:137:13)
    at flush (node_modules\q\q.js:125:13)
    at _combinedTickCallback (internal/process/next_tick.js:95:7)
    at process._tickDomainCallback (internal/process/next_tick.js:198:9)


  3) npm
       should have something come back for pageHistory:
     Uncaught Error: Invalid Chai property: object
    at Object.proxyGetter [as get] (node_modules\chai\lib\chai\utils\proxify.js:66:17)
    at test\npm.test.js:15:37
    at _fulfilled (node_modules\q\q.js:834:54)
    at self.promiseDispatch.done (node_modules\q\q.js:863:30)
    at Promise.promise.promiseDispatch (node_modules\q\q.js:796:13)
    at node_modules\q\q.js:556:49
    at runSingle (node_modules\q\q.js:137:13)
    at flush (node_modules\q\q.js:125:13)
    at _combinedTickCallback (internal/process/next_tick.js:95:7)
    at process._tickDomainCallback (internal/process/next_tick.js:198:9)

GerHobbelt added a commit to GerHobbelt/changelog that referenced this issue Oct 4, 2017
…eport anymore: `expect.an.object` is not the correct use: http://chaijs.com/api/bdd/ --> `expect.an('object')`
GerHobbelt added a commit to GerHobbelt/changelog that referenced this issue Oct 4, 2017
…eport anymore: `expect.an.object` is not the correct use: http://chaijs.com/api/bdd/ --> `expect.an('object')`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants