Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be explicit about CVXPY solvers #502

Open
Jacob-Stevens-Haas opened this issue May 13, 2024 · 0 comments
Open

Be explicit about CVXPY solvers #502

Jacob-Stevens-Haas opened this issue May 13, 2024 · 0 comments

Comments

@Jacob-Stevens-Haas
Copy link
Collaborator

CVXPY recently changed the default solver from ECOS to Clarabel. This means we need to go through the whole rejigging of "max_iter" vs "max_iters", because 1.5 causes tests to fail (see #500)

Describe the solution you'd like

I've currently sent a PR (#501) to limit the cvxpy version, but we ought to be more particular about which cvxpy solver we're using, rather than letting cvxpy choose. Otherwise, we'll end up back here.

Additional context

It is probably worth waiting to reconcile all of the TrappingSR3, ConstrainedSR3, StableLinearSR3 (and SINDyPI?) internals so that as much as possible dispatches to superclass, limiting our interface with cvxpy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant