Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all luacheck warnings #737

Open
jaromil opened this issue Oct 2, 2023 · 0 comments
Open

Fix all luacheck warnings #737

jaromil opened this issue Oct 2, 2023 · 0 comments

Comments

@jaromil
Copy link
Member

jaromil commented Oct 2, 2023

The Luacheck setup has improved to the point that all warnings are relevant and may point to a lack of local variable declarations or shadow values and other trivial errors in code. It makes sense to go through all of them and solve them whenever we have time (they are less than 400 at the time of writing this issue, with minor repetition).

apt-get install lua-check
luacheck --config src/lua/.luacheckrc --no-colors --codes src/lua/**.lua | less

Any check we want to deactivate has a W000 code that can be added to the .luackeckrc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant