Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyring should have a fix encoding #833

Open
matteo-cristino opened this issue Mar 14, 2024 · 1 comment
Open

Keyring should have a fix encoding #833

matteo-cristino opened this issue Mar 14, 2024 · 1 comment

Comments

@matteo-cristino
Copy link
Collaborator

Some keys in the keyring follow the CONF encoding during the output phase:

if obj.dilithium then res.dilithium = CONF.output.encoding.fun(obj.dilithium) end
if obj.kyber then res.kyber = CONF.output.encoding.fun(obj.kyber) end
if obj.schnorr then res.schnorr = CONF.output.encoding.fun(obj.schnorr) end
if obj.ntrup then res.ntrup = CONF.output.encoding.fun(obj.ntrup) end
if obj.eddsa then res.eddsa = O.to_base58(obj.eddsa) end

while in the input there is only a fixed encoding (for the above is base64).
I think that generally it is better if the keyring encoding is fixed, so that we are alsways sure with what type of encoding we have to load the key.

@jaromil
Copy link
Member

jaromil commented Apr 9, 2024

In cass we fix the encoding then base64 is preferred as requiring less changes, also is the most interoperable from shell scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants