Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: feat(crux): add dyrector.io platform template #443

Closed
wants to merge 3 commits into from
Closed

WIP: feat(crux): add dyrector.io platform template #443

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 26, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2023 •
edited

Codecov Report

Base: 17.55% // Head: 17.55% // No change to project coverage 👍

Coverage data is based on head (90651cf) compared to base (b8dd826).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #443   +/-   ##
========================================
  Coverage    17.55%   17.55%           
========================================
  Files           57       57           
  Lines         6089     6089           
========================================
  Hits          1069     1069           
  Misses        4938     4938           
  Partials        82       82

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@polaroi8d polaroi8d assigned ghost Jan 30, 2023
@polaroi8d polaroi8d added issue:enhancement New feature or request source:web The scope of the issue or pull request is web. pr:feat severity:medium labels Jan 30, 2023
nandor-magyar
nandor-magyar requested changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@nandor-magyar nandor-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only expose the ports, that are necessary to be exposed.

web/crux/templates/dyrector.io.json Outdated Show resolved Hide resolved
@ghost ghost force-pushed the feat/dyo_platform_template branch 2 times, most recently from 2180ab5 to 2d5f0c9 Compare February 1, 2023 14:37
@ghost ghost marked this pull request as ready for review February 1, 2023 15:45
@ghost ghost self-requested a review as a code owner February 1, 2023 15:45
@ghost
Copy link
Author

ghost commented Feb 1, 2023

Ready IMO, but couldn't test.

@ghost ghost force-pushed the feat/dyo_platform_template branch from 2d5f0c9 to 6dc113b Compare February 2, 2023 11:44
@m8vago
Copy link
Contributor

m8vago commented Feb 9, 2023

Why didn't you used the svg logo?

@polaroi8d
Copy link
Collaborator

Why didn't you used the svg logo?

We are using .jpg images for the templates, it's not final. (Have to change the logos to fit in the dark mode in the future, but not priority)

@polaroi8d
Copy link
Collaborator

Ready IMO, but couldn't test.

Can we test it right now?

@nandor-magyar nandor-magyar marked this pull request as draft February 15, 2023 16:10
@ghost ghost mentioned this pull request Mar 16, 2023
Open
@ghost ghost changed the title feat(crux): add dyrector.io platform template WIPfeat(crux): add dyrector.io platform template Mar 16, 2023
@ghost ghost changed the title WIPfeat(crux): add dyrector.io platform template WIP: feat(crux): add dyrector.io platform template Mar 16, 2023
@ghost
Copy link
Author

ghost commented Mar 16, 2023

Blocked for now...

@polaroi8d polaroi8d linked an issue Apr 27, 2023 that may be closed by this pull request
dyrector.io platform template #503
Open
@m8vago
Copy link
Contributor

m8vago commented May 10, 2023 •
edited

It still needs a major refactor in the template functionality, but that's not a priority right now.

@m8vago m8vago closed this May 10, 2023
@polaroi8d polaroi8d deleted the feat/dyo_platform_template branch December 4, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
issue:enhancement New feature or request pr:feat severity:medium source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dyrector.io platform template
4 participants
@codecov-commenter @m8vago @polaroi8d @nandor-magyar