Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More flexible CLI proxy configuration #583

Open
polaroi8d opened this issue May 5, 2023 · 0 comments
Open

More flexible CLI proxy configuration #583

polaroi8d opened this issue May 5, 2023 · 0 comments
Labels
issue:bug Something isn't working lang:golang pr:fix severity:medium source:cli The scope of the issue or pull request is CLI tool.

Comments

@polaroi8d
Copy link
Collaborator

polaroi8d commented May 5, 2023 •
edited

CLI configures environments according to the input parameters.

As of right now the --disable-crux and the --disable-crux-ui flags are not handled correctly, in case of these scenarios those components are running on the host machine.

Expected behavior:

  • only create the dynamic_conf.yml file if there is at least one disabled component
  • if only one is disabled the other should still function normally & get proxied using labels

Hint: changes affect (mostly) the golang/pkg/cli package.
@polaroi8d polaroi8d added issue:bug Something isn't working source:cli The scope of the issue or pull request is CLI tool. pr:fix lang:golang severity:medium labels May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue:bug Something isn't working lang:golang pr:fix severity:medium source:cli The scope of the issue or pull request is CLI tool.
Projects
🚧 Product Roadmap
Status: 🏄🏻‍♀️ Planned
Milestone
No milestone
Development

No branches or pull requests
1 participant
@polaroi8d