Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Makefile: check deps #628

Open
gerimate opened this issue May 18, 2023 · 6 comments
Open

Add Makefile: check deps #628

gerimate opened this issue May 18, 2023 · 6 comments
Labels
dependencies Pull requests that update a dependency file issue:good first issue Good for newcomers issue:hacktoberfest Issue marked as suitable for Hacktoberfest issue:improvement Issue that makes something better. lang:golang lang:makefile severity:high source:build Makefiles, Dockerfiles, etc

Comments

@gerimate
Copy link
Contributor

gerimate commented May 18, 2023 •
edited

Add intermediate pre-condition to make targets (root Makefile), as make dependencies to relevant code parts.

For golang code check go-dependencies, go-dev dependencies – separate.

For nodejs, the same.

These targets execute and if dependencies are missing or there is a version mismatch it bails with an exit code and an error.

Dependencies can be defined like so:

.PHONY target
target: dependency1 dependency2
  step1
  step2
@gerimate gerimate added issue:improvement Issue that makes something better. lang:golang lang:makefile severity:high dependencies Pull requests that update a dependency file source:build Makefiles, Dockerfiles, etc go labels May 18, 2023
@gerimate gerimate removed the go label Jun 5, 2023
@polaroi8d polaroi8d added issue:good first issue Good for newcomers issue:hacktoberfest Issue marked as suitable for Hacktoberfest labels Sep 28, 2023
@Cioraz
Copy link

Cioraz commented Oct 4, 2023

I dint quite understand the entire issue, could you elaborate?

@nandor-magyar
Copy link
Contributor

Hey @Cioraz! Welcome and thanks for reaching out. This should be pre-run test to make sure all the executables needed for development are available in PATH.

@kurayami07734
Copy link

I would like to work on this

@polaroi8d
Copy link
Collaborator

I would like to work on this

We haven't received a solution yet, so please proceed.

@Parvezkhan0 Parvezkhan0 mentioned this issue Jan 16, 2024
Closed
@Parvezkhan0
Copy link

@polaroi8d @nandor-magyar @gerimate I added dependency checks targets. Please review my PR

@polaroi8d
Copy link
Collaborator

Hi @Parvezkhan0, I've added a few thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file issue:good first issue Good for newcomers issue:hacktoberfest Issue marked as suitable for Hacktoberfest issue:improvement Issue that makes something better. lang:golang lang:makefile severity:high source:build Makefiles, Dockerfiles, etc
Projects
🚧 Product Roadmap
Status: 🏄🏻‍♀️ Planned
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dependency check targets to Makefile
6 participants
@polaroi8d @nandor-magyar @kurayami07734 @Cioraz @gerimate @Parvezkhan0