Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create yup validation unit tests for registrySchema() #851

Open
polaroi8d opened this issue Oct 11, 2023 · 4 comments
Open

Create yup validation unit tests for registrySchema() #851

polaroi8d opened this issue Oct 11, 2023 · 4 comments
Assignees
@Khalid-debugg
Labels
issue:good first issue Good for newcomers issue:hacktoberfest Issue marked as suitable for Hacktoberfest issue:improvement Issue that makes something better. lang:javascript lang:typescript severity:low source:web The scope of the issue or pull request is web.

Comments

@polaroi8d
Copy link
Collaborator

Right now, we need to cover the existing registrySchema() Yup validation with unit tests in this file: web/crux-ui/src/validation/registry.ts. You can find one unit test here: web/crux-ui/src/validation/registry.spec.ts. The task is to create more unit tests to cover all possible scenarios for the schema.

You can find the reference PR here: #850
@polaroi8d polaroi8d added issue:good first issue Good for newcomers issue:improvement Issue that makes something better. source:web The scope of the issue or pull request is web. issue:hacktoberfest Issue marked as suitable for Hacktoberfest lang:typescript severity:low lang:javascript labels Oct 11, 2023
@Khalid-debugg
Copy link

Can you assign this to me, please?

@polaroi8d
Copy link
Collaborator Author

Hi @Khalid-debugg, done.

@sanket95droid
Copy link

Can i work on this???

@polaroi8d
Copy link
Collaborator Author

Yes @sanket95droid 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Khalid-debugg Khalid-debugg

Labels
issue:good first issue Good for newcomers issue:hacktoberfest Issue marked as suitable for Hacktoberfest issue:improvement Issue that makes something better. lang:javascript lang:typescript severity:low source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@polaroi8d @Khalid-debugg @sanket95droid