Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor golang package builder to options #859

Open
gerimate opened this issue Oct 17, 2023 · 2 comments
Open

Refactor golang package builder to options #859

gerimate opened this issue Oct 17, 2023 · 2 comments
Assignees
Labels

Comments

@gerimate
Copy link
Contributor

gerimate commented Oct 17, 2023

We would like to refactor the existing code to follow a more idiomatic builder pattern for our present Docker container builder (golang/pkg/builder/container) in go. This will involve creating a new package named golang/pkg/builder/decker and implementing unit and integration tests to ensure the functionality remains intact. This is a reusable library for spawning docker containers with an interface for runtime independent extensibility.

Proposed Changes

  • Create a new Golang package named golang/pkg/builder/decker.
  • Implement unit and integration tests to validate the functionality.
  • Migrate the Docker client, image, and container name parameters to this new builder pattern.
  • Maintain the original feature set without introducing new functionality.
  • Ensure code coverage remains the same or improves during the refactor.

Additional Details

This refactor aims to make the codebase more idiomatic and maintainable. Other components of the stack shouldn't be modified. This is a fairly large task, but it doesn't involve the whole builder, so it's expected that new issues will be introduced regarding this refactor.

Definition of Done

  • The code is reviewed and approved.
  • All tests pass successfully.
  • Documentation is updated if necessary.
@Atharva1723
Copy link

Can I work on this issue ?

@polaroi8d
Copy link
Collaborator

polaroi8d commented Oct 19, 2023

@Atharva1723 for sure, I've assigned the issue to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants