Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive permissions #298

Open
nuschpl opened this issue Sep 1, 2022 · 12 comments
Open

Excessive permissions #298

nuschpl opened this issue Sep 1, 2022 · 12 comments
Labels
EMBA Research security security topics stale wontfix This will not be worked on

Comments

@nuschpl
Copy link

nuschpl commented Sep 1, 2022

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. EMBA installation (dev-mode/default mode)
  2. default-mde
  3. Use the firmware available here: N/A
  4. Start EMBA with the following parameters: ./emba.sh -f anyfirmware.bin
  5. See error
    With docker enabled this script needs root privileges

Expected behavior
There is no reason software of this kind should need root privileges every time. Especially when most of work is done within containers

@m-1-k-3
Copy link
Member

m-1-k-3 commented Sep 1, 2022

Currently EMBA needs root privs for multiple extraction modules, as well as for the chroot environment from the user-mode emulator.

@m-1-k-3 m-1-k-3 added the wontfix This will not be worked on label Sep 1, 2022
@nuschpl
Copy link
Author

nuschpl commented Sep 1, 2022

What kind of extraction needs root ? If you need chroot there is no problem with launching chroot command itself with sudo, instead of running full framework full of uncertain tools as root.
Why won't you preciselty state those issues so other could contribute to those subissues ? You are building security tool and ignoring basic security principles - AFAIR emulator is optional and the message says it's docker related . What is purpose for running containerized environmen at all if we don't care about security

@m-1-k-3
Copy link
Member

m-1-k-3 commented Sep 1, 2022

Why won't you preciselty state those issues so other could contribute to those subissues ?

Keep calm guy ... if you ask you get the info.

You are building security tool and ignoring basic security principles

On the other side you do not need to use it at all.

For all that are interested the following modules currently need root privs:

  • P10
  • P14
  • P18 Module removed
  • P19
  • P20
  • S115
  • L10

Probably other modules also need root privs. I need to check this in detail.

@github-actions
Copy link

This issue is stale because it has been open for 28 days with no activity.

@github-actions github-actions bot added the stale label Sep 30, 2022
@m-1-k-3 m-1-k-3 added the security security topics label Oct 19, 2022
@github-actions github-actions bot removed the stale label Oct 20, 2022
@github-actions
Copy link

This issue is stale because it has been open for 28 days with no activity.

@github-actions github-actions bot added the stale label Nov 18, 2022
@github-actions github-actions bot removed the stale label Jun 25, 2023
@github-actions
Copy link

This issue is stale because it has been open for 28 days with no activity.

@github-actions
Copy link

This issue is stale because it has been open for 28 days with no activity.

@github-actions github-actions bot added the stale label Oct 16, 2023
@farmmanic
Copy link

for sure its recommended to run nested vm's
i run the root commands in the docker image on the bottom of those nested vm's

@github-actions github-actions bot removed the stale label Mar 17, 2024
Copy link

This issue is stale because it has been open for 28 days with no activity.

@github-actions github-actions bot added the stale label Apr 14, 2024
@nuschpl
Copy link
Author

nuschpl commented Apr 14, 2024

How the #wontfix and #Research tags come all together, does it mean there is an intent to change current behaviour (ongoing work or PR accept) or not ?

@m-1-k-3
Copy link
Member

m-1-k-3 commented Apr 14, 2024

#research -> further research work needed to identify all the affected areas and start repairing them or find some solution
#wontfix -> we currently do not have the resources to fix this within the core team

If you would like to start digging into this issue you are welcome. We can use this issue for further discussions, as well as a dedicated disussion in the gh discussion area.

@github-actions github-actions bot removed the stale label Apr 15, 2024
Copy link

This issue is stale because it has been open for 28 days with no activity.

@github-actions github-actions bot added the stale label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EMBA Research security security topics stale wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants