Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Add a option to disable fetch ipinfo #26

Open
askfor opened this issue Dec 17, 2020 · 7 comments
Open

Add a option to disable fetch ipinfo #26

askfor opened this issue Dec 17, 2020 · 7 comments

Comments

@askfor
Copy link

askfor commented Dec 17, 2020

Hi, it seems we can't disable fetch ipinfo yet.
It'd be nice to add an option to disable ipinfo function, so Speedtest can run on the intranet.

@e7d
Copy link
Owner

e7d commented Jan 23, 2021

Hello @askfor

I can handle offline or intranet situations fairly easily, by making ipInfo fail silently, returning the sole IP, without further information. If I do so, no need to disable ipInfo check.

Would that be sufficient for you case scenario?

@askfor
Copy link
Author

askfor commented Jan 23, 2021

Hi,
Yes, it's sufficient for my case, and this solutions is also simpler for users.
Thanks.

@e7d
Copy link
Owner

e7d commented Jan 23, 2021

Okay then. I have it ready on the development branch. I will probably release a 0.5.3 soon enough, including the fix.

@askfor
Copy link
Author

askfor commented Feb 9, 2021

Hi, it seems the speed test will only start after the IP resolution failed?
How about making IP resolution asynchronously?
But anyway it works on the intranet, Thanks.

@mickeylieu
Copy link

Hi Michael - firstly, thanks for a great project!
I have the same issue as the OP - our intranet users won't have resolvable IPs
Either disabling the ipinfo or making it run async would be fantastic
Do you think you can push this up to the master branch/updated docker? I would love to test this out further

@askfor
Copy link
Author

askfor commented Feb 16, 2021

Either disabling the ipinfo or making it run async would be fantastic
Do you think you can push this up to the master branch/updated docker? I would love to test this out further

The latest docker image works on the intranet already.

@mickeylieu
Copy link

mickeylieu commented Feb 16, 2021

Thanks! We loaded the docker image but each test initiation takes about 2 mins for the ipinfo to timeout before the speedtest begins running - is there a switch or something we can do to stop the lookup? Otherwise the test works perfectly! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants