Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Earthly --ci mode should allow outputs in some cases #1200

Closed
2 tasks
vladaionescu opened this issue Sep 4, 2021 · 1 comment · Fixed by #1213
Closed
2 tasks

Earthly --ci mode should allow outputs in some cases #1200

vladaionescu opened this issue Sep 4, 2021 · 1 comment · Fixed by #1213
Assignees
@JosemyDuarte
Labels
good first issue Good for newcomers hacktoberfest type:enhancement Small feature requests / adjustments

Comments

@vladaionescu
Copy link
Member

Earthly --ci enables --use-inline-cache, --save-inline-cache and --no-output. It would be great if

  • The --no-output part could be negated if the user chooses to (e.g. --ci --output)
  • Output was automatically enabled when using --artifact or --image (e.g. --ci --artifact +target/file.o ./ or --image +target)
@vladaionescu vladaionescu added type:enhancement Small feature requests / adjustments good first issue Good for newcomers hacktoberfest labels Sep 4, 2021
@JosemyDuarte JosemyDuarte mentioned this issue Sep 15, 2021
Merged
@JosemyDuarte
Copy link
Contributor

Hi Vlad! I would be happy to contribute to this one. I have opened a PR with my understanding of the requirements. Open to any feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JosemyDuarte JosemyDuarte

Labels
good first issue Good for newcomers hacktoberfest type:enhancement Small feature requests / adjustments
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Earthly --ci mode should allow outputs in some cases JosemyDuarte/earthly
2 participants
@vladaionescu @JosemyDuarte