Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create builtin ARG EARTHLY_VERSION #1452

Closed
cehoffman opened this issue Nov 28, 2021 · 1 comment · Fixed by #1478
Closed

Create builtin ARG EARTHLY_VERSION #1452

cehoffman opened this issue Nov 28, 2021 · 1 comment · Fixed by #1478
Assignees
Labels
good first issue Good for newcomers type:enhancement Small feature requests / adjustments

Comments

@cehoffman
Copy link

This would be useful for referencing the docker setup script to make an image suitable for use WITH DOCKER, e.g. DO github.com/earthly/lib:$EARTHLY_VERSION+INSTALL_DIND

@vladaionescu vladaionescu added type:enhancement Small feature requests / adjustments good first issue Good for newcomers labels Nov 29, 2021
@alexcb
Copy link
Collaborator

alexcb commented Nov 29, 2021

https://github.com/earthly/earthly/blob/main/variables/builtin.go#L18 is where we can add a new entry for EARTHLY_VERSION.

Perhaps we should also include EARTHLY_BUILD_SHA, which would point to the corresponding git sha that was used for the build?

Here are the relevant strings that are set at build time and would need to be propigated into builtin.go: https://github.com/earthly/earthly/blob/main/cmd/earthly/main.go#L168-L172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type:enhancement Small feature requests / adjustments
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants