Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to use ssh-ed25519 key: failed to create account: failed to create account: Internal #1783

Closed
Tracked by #2237
alexcb opened this issue Mar 28, 2022 · 3 comments
Assignees
Labels
type:enhancement Small feature requests / adjustments

Comments

@alexcb
Copy link
Collaborator

alexcb commented Mar 28, 2022

Earthly only supports ssh-rsa (and ssh-rsa2 256/512) keys. Support is needed for ssh-ed25519.

@alexcb
Copy link
Collaborator Author

alexcb commented Mar 28, 2022

Currently the server returns a 500 error, which results in:

retrying http request due to unexpected status code 500: Internal Server
Error
retrying http request due to unexpected status code 500: Internal Server
Error
retrying http request due to unexpected status code 500: Internal Server
Error
retrying http request due to unexpected status code 500: Internal Server
Error
retrying http request due to unexpected status code 500: Internal Server
Error
retrying http request due to unexpected status code 500: Internal Server
Error
retrying http request due to unexpected status code 500: Internal Server
Error
retrying http request due to unexpected status code 500: Internal Server
Error
retrying http request due to unexpected status code 500: Internal Server
Error
retrying http request due to unexpected status code 500: Internal Server
Error
Error: failed to create account: failed to create account: Internal
Server Error

At the very least, the server should return:

  1. some sort of permanent error, which would prevent the earthly client from re-attempting, and
  2. a meaningful error message

@alexcb alexcb added the type:enhancement Small feature requests / adjustments label Mar 28, 2022
@alexcb alexcb self-assigned this Oct 5, 2022
@alexcb
Copy link
Collaborator Author

alexcb commented Oct 5, 2022

in order to support this, we will have to make changes to both the server and client; as we currently assume it's ssh-rsa in the client code, e.g. here: 561331d#diff-a59bcc9da3758e095acce0cf0e47eed93c85022529e353fb48d42f05ce2f418bR285

We should make this change before VERSION 0.7 is released.

@alexcb
Copy link
Collaborator Author

alexcb commented Oct 21, 2022

This is supported as of https://github.com/earthly/earthly/releases/tag/v0.6.27

@alexcb alexcb closed this as completed Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Small feature requests / adjustments
Projects
None yet
Development

No branches or pull requests

1 participant