Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some shell-out expressions don't work well #2340

Closed
vladaionescu opened this issue Nov 1, 2022 · 0 comments · Fixed by #2419
Closed

Some shell-out expressions don't work well #2340

vladaionescu opened this issue Nov 1, 2022 · 0 comments · Fixed by #2419
Labels
type:bug Something isn't working

Comments

@vladaionescu
Copy link
Member

The following expression does not work with VERSION --shell-out-anywhere:

ARG foo = "$(echo '()')"

which is surprising. The following versions do work, however:

ARG foo = "$(echo \\(\\))"
ARG foo = $(echo \\(\\))

Incidentally, without --shell-out-anywhere, all three versions work.
@vladaionescu vladaionescu added the type:bug Something isn't working label Nov 1, 2022
alexcb added a commit that referenced this issue Nov 16, 2022
@alexcb
fix singlequote parsing for --shell-out-anywhere
9994158 
lexer was incorrectly removing first character when parsing single
quotes within a shellout. fixes #2340

Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
@alexcb alexcb mentioned this issue Nov 16, 2022
Merged
alexcb added a commit that referenced this issue Nov 17, 2022
@alexcb
fix singlequote parsing for --shell-out-anywhere (#2419)
f489554 
lexer was incorrectly removing first character when parsing single
quotes within a shellout. fixes
#2340

Signed-off-by: Alex Couture-Beil <alex@earthly.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix singlequote parsing for --shell-out-anywhere earthly/earthly
1 participant
@vladaionescu