Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard BUILDs not taking target path into account. #3840

Closed
mikejholly opened this issue Feb 27, 2024 · 0 comments
Closed

Wildcard BUILDs not taking target path into account. #3840

mikejholly opened this issue Feb 27, 2024 · 0 comments
Assignees
Labels
type:bug Something isn't working

Comments

@mikejholly
Copy link
Contributor

Should the expansion of wildcards take the path of the target into account?
For context, I ran into the following scenario:

directory:

~/projects/lib/utils (main*) » ls -1R Earthfile */Earthfile                                                                                      
Earthfile
dind/Earthfile
git/Earthfile
github/Earthfile
ssh/Earthfile

~/projects/lib/utils/Earthfile:

VERSION --wildcard-builds 0.8

test:
    BUILD ./*+test

earthly command:

~/projects/lib (main*) » earthly ./utils+test                                                                                                1 ↵ idodavid@Idos-MacBook-Air
 Init 🚀
————————————————————————————————————————————————————————————————————————————————

           buildkitd | Found buildkit daemon as docker container (earthly-buildkitd)

Streaming logs to https://cloud.earthly.dev/builds/79f27edd-b7d2-4026-be65-7be9d63799d4

 Build 🔧
————————————————————————————————————————————————————————————————————————————————

        ./utils+test | --> FROM +base
              output | --> exporting outputs

 Push Summary ⏫ (disabled)
————————————————————————————————————————————————————————————————————————————————

To enable pushing use earthly --push

 Local Output Summary 🎁
————————————————————————————————————————————————————————————————————————————————



========================== 🌍 Earthly Build  ✅ SUCCESS ==========================

View logs at https://cloud.earthly.dev/builds/79f27edd-b7d2-4026-be65-7be9d63799d4

This does work if I cd utils and then:

~/projects/lib/utils (main*) » earthly +test
@mikejholly mikejholly added the type:bug Something isn't working label Feb 27, 2024
mikejholly added a commit that referenced this issue Feb 28, 2024
Addresses: #3840

Wildcard `BUILD`'s will now account for the correct file path when
building using a relative target path (e.g., `earthly ./some/dir/*+test`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

1 participant