Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot COPY files containing + #502

Closed
vladaionescu opened this issue Nov 11, 2020 · 1 comment · Fixed by #503
Closed

Cannot COPY files containing + #502

vladaionescu opened this issue Nov 11, 2020 · 1 comment · Fixed by #503
Assignees
Labels
type:bug Something isn't working

Comments

@vladaionescu
Copy link
Member

vladaionescu commented Nov 11, 2020

Dan Miller (@jazzdan) reports on Slack

I want to COPY a file in an Earthfile that has a + in it (like COPY lib/7z lib/7z.so lib/libc++.dylib lib/libsystem_c.dylib /), but when I do Earth complains:

Error: build target: build main: bkClient.Build: failed to solve: rpc error: code = Unknown desc = parse: Combining artifacts and build context arguments in a single COPY command is not allowed: [lib/7z lib/7z.so lib/libc++.dylib lib/libsystem_c.dylib]

Is there a way to escape the + or something?

We should support escaping the + in COPY commands (eg \+).

We should test:

  • COPY a file containing a + from build context
  • COPY an artifact containing a + from another target
  • Three tests where each of the SAVE ARTIFACT params contains a +
@vladaionescu
Copy link
Member Author

This will be in the next release @jazzdan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant