Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WITH DOCKER - possible regression in v0.4.2 #676

Closed
visciang opened this issue Dec 24, 2020 · 3 comments
Closed

WITH DOCKER - possible regression in v0.4.2 #676

visciang opened this issue Dec 24, 2020 · 3 comments

Comments

@visciang
Copy link

Issue seen in v0.4.2, it works as expected in v0.4.1.

It seems the loaded image (WITH DOCKER --load external-image:latest=+external-image) is not available in the docker-compose "context".

To reproduce the issue:
https://github.com/visciang/issue-earthly-docker-compose

$ earthly -P +test
           buildkitd | Found buildkit daemon as docker container (earthly-buildkitd)
        earthly/dind | --> Load metadata (linux/amd64)
             context | --> local context .
               +base | --> FROM earthly/dind
               +base | [          ] resolve docker.io/earthly/dind@sha256:210c526a401e2f4529a207a0510c2882393a[██████████] resolve docker.io/earthly/dind@sha256:210c526a401e2f4529a207a0510c2882393a4ca2027dcf874b6820fbdf1de894 ... 100%
             context | [██████████] transferring .: ... 100%
               +test | *cached* --> COPY docker-compose.yml .
               +test | *cached* --> WITH DOCKER (install deps)
               +test | *cached* --> WITH DOCKER (docker-compose config)
external-image:latest | --> Load metadata (linux/amd64)
external-image:latest | WARN: (Load metadata (linux/amd64)) pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed
Error: authorization failed
@adamgordonbell
Copy link
Contributor

adamgordonbell commented Dec 24, 2020

Thanks for finding this @visciang.

I can reproduce the issue.

@vladaionescu
Copy link
Member

vladaionescu commented Dec 28, 2020

Thanks for the report @visciang. It seems that this no longer reproduces on the main branch. v0.4.3 (just released) should fix this for you. Let me know if you run into any trouble!

Screenshot from 2020-12-28 10-27-15

@visciang
Copy link
Author

Tested right now on "the real thing" and it works as expected.
Thank you @vladaionescu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants