Required ARGs #904
Labels
good first issue
Good for newcomers
hacktoberfest
type:enhancement
Small feature requests / adjustments
Comments
|
This might be a good first issue if anyone wants to take it on. We would need a new struct for ARG options under https://github.com/earthly/earthly/blob/main/earthfile2llb/flags.go then, under |
alexcb
pushed a commit
that referenced
this issue
Oct 21, 2021
* Implement Required ARGs #904 * File cannot have default value for --required args * Allow optional flag for ARG in earthfile syntax * Error if build-arg not provided for required ARG Minimal behavior verification test: https://asciinema.org/a/441110 * Add feature test and update ARG docs * Implement Required ARGs #904 * File cannot have default value for --required args * Allow optional flag for ARG in earthfile syntax * Error if build-arg not provided for required ARG Minimal behavior verification test: https://asciinema.org/a/441110 * Add feature test and update ARG docs * Add test that args are required, move file after rebase * Update required-args.earth Remove double newline, add newline at end of required-args.earth for linter
|
this has been released and is available under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some UDCs (or even targets) could benefit from strictly required ARGs - ARGs that must be passed in, in order for the command (or target) to work.
This helps eliminate cases where the user is chasing their tail trying to figure out what's wrong when an ARG is unexpectedly set to
""when declared asARG somethingand no value is provided on the call itself.Sytanx suggestion:
Required ARGs can never have a default value.
CC @jazzdan
The text was updated successfully, but these errors were encountered: