Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue] golang/protobuf warning #36

Closed
bigangryrobot opened this issue Jun 17, 2021 · 3 comments
Closed

[issue] golang/protobuf warning #36

bigangryrobot opened this issue Jun 17, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bigangryrobot
Copy link
Contributor

Receiving this warning message when executing the server code locally

WARNING: Package "github.com/golang/protobuf/protoc-gen-go/generator" is deprecated.
	A future release of golang/protobuf will delete this package,
	which has long been excluded from the compatibility promise.
@zhao-kun zhao-kun added this to To do in Easegress Project via automation Jun 18, 2021
@benja-wu benja-wu self-assigned this Jun 18, 2021
@benja-wu
Copy link
Contributor

Thanks for reminding this. As running the go mod why check, seems that

√ easegress $ go mod why github.com/golang/protobuf/protoc-gen-go/generator
# github.com/golang/protobuf/protoc-gen-go/generator
github.com/megaease/easegress/pkg/cluster
go.etcd.io/etcd/embed
github.com/grpc-ecosystem/grpc-gateway/runtime
github.com/golang/protobuf/protoc-gen-go/generator

this warning is caused by grpc-gateway in etcd. In this release-note, grpc-gatway project had removed this dependence in 1.14.5.
We will figure out which latest version could be stable and also been able to remove this warning.

@xxx7xxxx
Copy link
Contributor

This is because etcd[1] used grpc-gateway[2] needs the package golang/protobuf. Fixed by grpc-ecosystem/grpc-gateway#1260

The upgrade[3] of etcd will fix it.

[1] etcd-io/etcd#12124
[2] https://github.com/grpc-ecosystem/grpc-gateway
[3] https://github.com/etcd-io/etcd/blob/main/CHANGELOG-3.5.md#package-clientv3

@zhao-kun zhao-kun added this to the v1.0.1 milestone Jun 18, 2021
@benja-wu benja-wu added the enhancement New feature or request label Jun 18, 2021
@zhao-kun zhao-kun moved this from To do to Review in progress in Easegress Project Jun 18, 2021
@benja-wu
Copy link
Contributor

Merged by #38

Easegress Project automation moved this from Review in progress to Done Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

4 participants