Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checksums have changed for all libxc versions #20417

Open
schiotz opened this issue Apr 25, 2024 · 5 comments
Open

Checksums have changed for all libxc versions #20417

schiotz opened this issue Apr 25, 2024 · 5 comments

Comments

@schiotz
Copy link
Contributor

schiotz commented Apr 25, 2024

Hi,

It looks like checksums have changes for all .tar.gz files downloaded by all (recent?) versions of libxc easyconfigs. The files are "release assets" on gitlab, I don't suppose those should change. Does anyone know if this is anyhow expected - I am wary of just changing the checksums in case something fishy is going on.

Also, I notices that two checksums are given although only one file is downloaded, could that be because this has happened before and the new checksums have just been added to the list?

/Jakob

CC: @OleHolmNielsen

@zao
Copy link
Contributor

zao commented May 2, 2024

Someone ran into this on Slack today, I took a look and it seems like there's not much stability in the checksums generated for these tarballs on GitLab.

On the dual checksums, the first set is from when we used to take libxc sources from another site; GitLab as a source was added in late March this year in #20163 as the first place became defunct. This introduced a new checksum.

Unfortunately, it seems like GitLab is still GitLab and doesn't necessarily have stable checksums on "release assets", which probably are generated on the fly from tags and other repo state.

For example for libxc-5.1.6.tar.gz, I'm getting one checksum and a reporter on Slack is getting another:

bcdf597593a80e53c4e2f6cab486c435fb497d2afe1819debd8e225597015913  xc-new/libxc-5.1.6.tar.gz
0d8e62f619b72b3af1694f13cfdffad94ccbeefcbdc5e2765d2e9f930c6f5792 /home/redacted/ebsrcs/l/libxc/libxc-5.1.6.tar.gz

This might need some investigation into whether GitLab is being silly again with regard to stable archive generation.

@boegel
Copy link
Member

boegel commented May 2, 2024

see also #20452

@boegel boegel added this to the release after 4.9.1 milestone May 2, 2024
@boegel
Copy link
Member

boegel commented May 2, 2024

I've opened an issue upstream for this, since I'm not seeing any differences for other projects hosted on GitLab: https://gitlab.com/libxc/libxc/-/issues/511

@appolloford
Copy link
Contributor

Sorry, I just read through all the discussion. I only noticed that a few files are different since the last time the source was downloaded from Gitlab. I don't know whether they can be modified from Gitlab autogenerated tarball, but if so that may mean the history has been rebased?

Only in new/libxc-4.3.4: .codecov.yml
Only in new/libxc-4.3.4: .gitignore
Only in new/libxc-4.3.4: Doxyfile
Only in old/libxc-4.3.4: Makefile.in
Only in new/libxc-4.3.4: README.md
Only in old/libxc-4.3.4: aclocal.m4
Only in new/libxc-4.3.4: appveyor.yml
Only in old/libxc-4.3.4/build: Makefile.in
Only in old/libxc-4.3.4/cmake: Makefile.in
Only in old/libxc-4.3.4: compile
Only in old/libxc-4.3.4: config.guess
Only in old/libxc-4.3.4: config.h.in
Only in old/libxc-4.3.4: config.sub
Only in old/libxc-4.3.4: configure
Only in old/libxc-4.3.4: depcomp
Only in new/libxc-4.3.4: examples
Only in old/libxc-4.3.4: install-sh
Only in new/libxc-4.3.4: libxc.bib
Only in old/libxc-4.3.4: ltmain.sh
Only in old/libxc-4.3.4/m4: libtool.m4
Only in new/libxc-4.3.4/m4: libxc.m4
Only in old/libxc-4.3.4/m4: ltoptions.m4
Only in old/libxc-4.3.4/m4: ltsugar.m4
Only in old/libxc-4.3.4/m4: ltversion.m4
Only in old/libxc-4.3.4/m4: lt~obsolete.m4
Only in old/libxc-4.3.4/maple: Makefile.in
Only in new/libxc-4.3.4/maple: gga_c_ft97.mpl
Only in new/libxc-4.3.4/maple: gga_x_chachiyo.mpl
Only in new/libxc-4.3.4/maple: gga_x_pbetrans.mpl
Only in new/libxc-4.3.4/maple: lda_c_lp96.mpl
Only in new/libxc-4.3.4/maple: mgga_x_m06l.mpl
Only in old/libxc-4.3.4: missing
Only in old/libxc-4.3.4/pylibxc: Makefile.in
Only in old/libxc-4.3.4/scripts: Makefile.in
Only in new/libxc-4.3.4/scripts: maple2c_info
Only in new/libxc-4.3.4/scripts: mk_work_info.pl
Only in old/libxc-4.3.4/src: Makefile.in
Only in old/libxc-4.3.4/src/maple2c: Makefile.in
Only in new/libxc-4.3.4/src: test.c
Only in old/libxc-4.3.4: test-driver
Only in old/libxc-4.3.4/testsuite: Makefile.in
Only in new/libxc-4.3.4/testsuite: atomic_densities
Only in old/libxc-4.3.4/testsuite/pytest: Makefile.in
Only in new/libxc-4.3.4/testsuite/regression/gga_c: disabled
Only in new/libxc-4.3.4/testsuite/regression/gga_k: disabled
Only in new/libxc-4.3.4/testsuite/regression/gga_x: disabled
Only in new/libxc-4.3.4/testsuite/regression/gga_xc: disabled
Only in new/libxc-4.3.4/testsuite/regression/hyb_gga_x: disabled
Only in new/libxc-4.3.4/testsuite/regression/hyb_gga_xc: disabled
Only in new/libxc-4.3.4/testsuite/regression/hyb_mgga_x: disabled
Only in new/libxc-4.3.4/testsuite/regression/hyb_mgga_xc: disabled
Only in new/libxc-4.3.4/testsuite/regression/lda_x: disabled
Only in new/libxc-4.3.4/testsuite/regression/mgga_c: disabled
Only in new/libxc-4.3.4/testsuite/regression/mgga_x: disabled
Only in new/libxc-4.3.4/testsuite/regression/mgga_xc: disabled
Only in new/libxc-4.3.4/testsuite: xc-reset-regression
Only in old/libxc-4.3.4: xc_version.h

@boegel boegel changed the title Checksums have changes for all libxc versions Checksums have changed for all libxc versions May 24, 2024
@boegel
Copy link
Member

boegel commented May 24, 2024

I think it would be helpful if others also comment in https://gitlab.com/libxc/libxc/-/issues/511, to make it clear to the libxc team that this doesn't affect just me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants