Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove s390x/ppc64le arches in che container builds #21969

Closed
2 tasks
nickboldt opened this issue Jan 30, 2023 · 3 comments
Closed
2 tasks

Remove s390x/ppc64le arches in che container builds #21969

nickboldt opened this issue Jan 30, 2023 · 3 comments
Labels
area/ci/multi-arch Issues and PRs related to the release of images targeting architectures other than amd64 kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@nickboldt
Copy link
Contributor

nickboldt commented Jan 30, 2023

Is your task related to a problem? Please describe

Today, we have builds that use docker buildx to create containers for the following arches:

  • che-code: amd64 
  • che-dashboard: amd64, arm64, ppc64le
  • che-devfile-registry: amd64 
  • che-docs: amd64 
  • che-e2e: amd64 
  • kubernetes-image-puller: amd64
  • che-machine-exec: amd64, arm64, ppc64le
  • che-operator: amd64, ppc64le
  • che-plugin-registry: amd64 
  • configbump: amd64, arm64, ppc64le, s390x (last built in 2021!)
  • developer-images (UDI): amd64 

We also have other builds that are simple single arch:

  • devworkspace-operator
  • che-server
  • che-theia

And we have chectl, which is built for many arches, including Mac and Windows:

  • chectl: linux-arm,linux-x64,linux-s390x,linux-ppc64le,darwin-x64,darwin-arm64,win32-x64,win32-x86

Questions

  1. Why are we building some components of Che for multiple arches? Is there a compelling reason to have a dashboard and server/factory, without the ability to launch a workspace running che-code?

  2. Can you even install the Che operator without a compatible DevWorkspace operator for your arch? (I would be surprised if this is possible.)

  3. Could we simplify the Che build infrastructure to use podman build or docker build instead of docker buildx, and focus on the single end to end deployment of Che on amd64?

For those worried that this means they can't use Windows to Mac to connect to their cluster, don't worry - I'm not suggesting we drop support of darwin or win32 arches.

I'm suggesting we drop container builds for arm64, s390x, and ppc64le, since there is no way to use those containers for a COMPLETE Che 7.60+ deployment with a vscode-based workspace.

Describe the proposed solution:

Plan after discussions with @l0rd:

Describe alternatives you've considered

Given we have tried to build Che components with Z and P without success (both using GH actions and Travis), those arches should definitely be dropped, as they are available downstream in Red Hat OpenShift Dev Spaces but the upstream images are not usable.

Support for arm64 could be explored if there's a need, but given today we only have arm images for dashboard, machine-exec, and configbump, that would be a long road to travel without a compelling reason to do so.

Additional context

Question also sent to https://www.eclipse.org/lists/che-dev/msg04456.html for consideration.

See also:

@nickboldt nickboldt added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jan 30, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 30, 2023
@nickboldt
Copy link
Contributor Author

See also #21954

@AObuchow AObuchow added severity/P2 Has a minor but important impact to the usage or development of the system. area/ci/multi-arch Issues and PRs related to the release of images targeting architectures other than amd64 and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 31, 2023
@nickboldt
Copy link
Contributor Author

nickboldt commented Feb 6, 2023

Revised plan after discussions with @l0rd:

@nickboldt nickboldt changed the title Remove unused arches in che container builds Remove s390x/ppc64le; add arm64 arches in che container builds Feb 14, 2023
@nickboldt nickboldt added the kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. label Feb 15, 2023
@nickboldt nickboldt changed the title Remove s390x/ppc64le; add arm64 arches in che container builds Remove s390x/ppc64le arches in che container builds Feb 16, 2023
@nickboldt nickboldt mentioned this issue Mar 8, 2023
7 tasks
@che-bot
Copy link
Contributor

che-bot commented Aug 15, 2023

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 15, 2023
@che-bot che-bot closed this as completed Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci/multi-arch Issues and PRs related to the release of images targeting architectures other than amd64 kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants