Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add istack-commons-tools to jaxb-bom #1744

Open
mattrpav opened this issue Sep 13, 2023 · 6 comments
Open

Add istack-commons-tools to jaxb-bom #1744

mattrpav opened this issue Sep 13, 2023 · 6 comments

Comments

@mattrpav
Copy link

Currently istack-commons-runtime is listed in the bom, but istack-commons-tools is not.

xsom has a transitive dep on istack-common-sools

@antoniosanct
Copy link
Contributor

Hi, @mattrpav

xsom has a transitive dep on istack-common-sools

Where did you see it?

Regards,
Antonio.

@mattrpav
Copy link
Author

mattrpav commented Sep 14, 2023

dtd-parser rather

[INFO] +- org.glassfish.jaxb:jaxb-xjc:jar:3.0.2:compile
[INFO] |  +- org.glassfish.jaxb:xsom:jar:3.0.2:compile
[INFO] |  |  \- com.sun.xml.bind.external:relaxng-datatype:jar:3.0.2:compile
[INFO] |  +- org.glassfish.jaxb:codemodel:jar:3.0.2:compile
[INFO] |  +- com.sun.xml.bind.external:rngom:jar:3.0.2:compile
[INFO] |  +- com.sun.xml.dtd-parser:dtd-parser:jar:1.4.5:compile
[INFO] |  \- com.sun.istack:istack-commons-tools:jar:4.0.1:compile

@antoniosanct
Copy link
Contributor

antoniosanct commented Sep 14, 2023

Hi, @mattrpav
Then dtd-parser is not belonging to jaxb-ri, but eclipse-ee4j/jaxb-dtd-parser it is. I think this issue doesn't apply here.
Regards,
Antonio.

@mattrpav
Copy link
Author

Hmm.. looks like jaxb-ri/xjc has a direct dependency on both dtd-parser and istack-common-tools

...
        <dependency>
            <groupId>com.sun.xml.dtd-parser</groupId>
            <artifactId>dtd-parser</artifactId>
        </dependency>
        <dependency>
            <groupId>com.sun.istack</groupId>
            <artifactId>istack-commons-tools</artifactId>
        </dependency>
...

ref:

<dependency>

@laurentschoelens
Copy link
Contributor

@mattrpav : maybe we should switch to https://github.com/eclipse-ee4j/jaxb-ri/blob/master/jaxb-ri/boms/bom-ext/pom.xml
This one contains more jaxb dependencies that we use...

@mattrpav
Copy link
Author

My view on BOM use cases:

  1. jaxb-api, jaxb-impl users (need the JAXB API, JAXB impl and transitive deps for doing marshal/unmarshal of XML <-> Java.
  2. xjc schema-to-code generating users. Includes everything from Supporting Appendix E.2 #1 and adds the xjc deps
  3. SPI-side users. Like, highsource/jaxb-tools. Maven modules, xjc plugins, episode handlers and schema location resolving, etc. This is an advanced use case.

jaxb-ri/bom - users #1 and #2 as it is most 'software developers using jaxb'
jaxb-ri/bom-ext - jaxb tools developers who are implementing and extending jaxb stuff

If the above is agreed, then it would make sense to include istack-commons-tools in the bom pom to support software developers using xjc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants