Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullability annotations #586

Open
NickAcPT opened this issue Dec 31, 2021 · 1 comment
Open

Add nullability annotations #586

NickAcPT opened this issue Dec 31, 2021 · 1 comment

Comments

@NickAcPT
Copy link

Several methods and are missing nullability annotations (@NonNull or @Nullable).

This results in a poor experience in languages like Kotlin because method arguments and return types do not contain the correct nullable or non-null types.

@jonahgraham
Copy link
Contributor

Hi @NickAcPT - I would be happy to review/merge a pull request that added such annotations. It may be best to do a single file first to make sure we are all on the same page. For example, the @NonNull annotation in the code today is org.eclipse.lsp4j.jsonrpc.validation.NonNull which may not be what you expect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants