Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven build shortcut not working #1618

Open
georgeoikawapp opened this issue Dec 7, 2023 · 6 comments
Open

Maven build shortcut not working #1618

georgeoikawapp opened this issue Dec 7, 2023 · 6 comments

Comments

@georgeoikawapp
Copy link

In eclipse 2023-06 the maven build shortcut (alt+shift+x+m) is ok, mas upgrande to version 2023-09 and 2023-12 the shortcut doesnt work anymore.

@Omega1001
Copy link

Hi,
just run into the same problem.
This seems to be a side effect of 289595f (#1452)

The Keyboard shortcut references the removed buttons command id, so after removing it, the shortcut no longer works.

I would further argue, that the shortcut is not obsolete: If one would create 50+ maven run configs for one project (unlikely but possible) the Menu would explode. Thus its length should be limited, offering the maven build button at access the scrawlable dialog with all configs to select the one you want.

As this is easily one of the shortcut I use most, i would suggest at the least, to reverting this change.

As a workaround: As the change is only on the plugin.xml, you can extract eclipseSetup\plugins\org.eclipse.m2e.launching_XXXX.jar, revert the change to the plugin.xml manually (by copying the shortcut back in) and rezip it. After restarting Eclipse, the Button will be back in the Run as menu and the Keyboard shortcut will work again.

@laeubi
Copy link
Member

laeubi commented Jan 11, 2024

Please provide a fix, the most suitable one seems to assign the shortcut to the Dialog oriented one then ...

If one would create 50+ maven run configs for one project (unlikely but possible) the Menu would explode

You can always abuse a feature, though we try to support the common case not the one that makes use of unrealistic corner cases.

@Omega1001
Copy link

@laeubi The Dialog I'm referring to is the on that was linked to the old Button. The ExecutePomAction:WITH_DIALOG action appears to linkt to the "Create New" Dialog, which is not wanted here, as it would lead to creating a new run config for every run (which would end up being the 50+ use case).

If there is an other, better Dialog you reference, I have never seen it before. So could you please point me in the right direction?

For my perspective, revering (#1452) is the easiest. The additional Button doesn't hurt anyone, does it?

@laeubi
Copy link
Member

laeubi commented Jan 11, 2024

Please share a screenshot then, there was no button removed, just a Menu item, that menu items also usually have no dialog unless you have no run config (what the existing one would show), the shortcut can simply made to run the last selected run config though it does not need to always create a new one.

As you already mentioned to many items can 'blow up' the thing so we should not add items that are already there.

@Omega1001
Copy link

Ok, sorry for causing confusion: Of cause i mean the the menu Item that (used to be) under Run as/Maven Build (without the three dots), that was also bound the the keybord shortcut in question.
MeunItem

Its behaviour used to be:

  • If no config available, Create one.
  • If exactly one Config, execute it.
  • If more than one, show this selection dialog:
    Unbenannt

Please note, that for demo, i just cloned the first Run config, that's why the name and goals are almost identical.

Personally, if there are many Run configurations, i prefer this already existing Dialog, because it is filterable AND scrawlable.
Also it was accessible by keyboard shortcuts, speeding up usage.

Thus, i would just restore it, the way it was.

@laeubi
Copy link
Member

laeubi commented Jan 11, 2024

@mickaelistria is it possible to have a shortcut but still not show the menu item? I think I have seen it that one can even make it somehow configurable in the perspective preferences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants