Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[electron] Missing content in debug view #3679

Closed
mark-edgeworth opened this issue Nov 29, 2018 · 7 comments
Closed

[electron] Missing content in debug view #3679

mark-edgeworth opened this issue Nov 29, 2018 · 7 comments
Labels
bug bugs found in the application debug issues that related to debug functionality electron issues related to the electron target

Comments

@mark-edgeworth
Copy link
Contributor

When I run the UI in electron and attempt to debug some JS the Variables and Breakpoints sections of the debug pane are empty.

However, when I run the backend (using Launch Backend) and connect using a browser the variables and breakpoints sections of the debug view are filled-in correctly.

Run with master as of this morning.

@mark-edgeworth
Copy link
Contributor Author

To be clear, I did add a single breakpoint and theia was correctly stopped at it.

@akosyakov akosyakov added bug bugs found in the application electron issues related to the electron target debug issues that related to debug functionality labels Nov 30, 2018
@akosyakov akosyakov self-assigned this Nov 30, 2018
@akosyakov
Copy link
Member

@mark-edgeworth Hi 👋

Can you check please your backend logs? Do you see something like here: #3408 (comment)

@akosyakov
Copy link
Member

I was able to reproduce it, it does not seem to be related to #3408

@akosyakov akosyakov removed their assignment Nov 30, 2018
@akosyakov
Copy link
Member

The fundamental issue that we use runtime features from es5 which are not supported in Node.js version bundled with Electron 1.8.2. I would prefer that we move to the latest stable Electron.

@mark-edgeworth Could someone from ARM to have a look at #3693?

@thegecko
Copy link
Member

thegecko commented Nov 30, 2018

@akosyakov We are keen to bump up the electron version. Let me investigate the work needed.

@kittaakos kittaakos changed the title Missing content in debug view [electron] Missing content in debug view Nov 30, 2018
@akosyakov
Copy link
Member

@thegecko there can be a bit more work, in addition, to bumping up the electron version :) related to nsfw package @kittaakos should know better

@thegecko
Copy link
Member

thegecko commented Dec 4, 2018

This should be fixed when the Array.values() usages are removed as part of #3730 .

akosyakov added a commit that referenced this issue Dec 7, 2018
Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
bogthe pushed a commit to ARMmbed/theia that referenced this issue Jan 21, 2019
Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
Signed-off-by: Bogdan Stolojan <petre.stolojan@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application debug issues that related to debug functionality electron issues related to the electron target
Projects
None yet
Development

No branches or pull requests

3 participants