Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forceContextQualifier has been broken since Tycho 4.0.5 #3809

Open
orionll opened this issue May 3, 2024 · 0 comments
Open

forceContextQualifier has been broken since Tycho 4.0.5 #3809

orionll opened this issue May 3, 2024 · 0 comments

Comments

@orionll
Copy link

orionll commented May 3, 2024

There is an infinite recursion in AbstractTychoMapping.modelHasProperty if Tycho build is called with -DforceContextQualifier.
Steps to reproduce:

  • Clone https://github.com/vogellacompany/tycho-example
  • Run mvn clean verify -DskipTests -DforceContextQualifier=100500
  • The build runs fine because the version of Tycho in the project is 4.0.4
  • Now change the version of Tycho to 4.0.5 (or 4.0.6/4.0.7) in pom.xml and .mvn/extensions.xml
  • Run mvn clean verify -DskipTests -DforceContextQualifier=100500 again
  • The build is running much slower (or fails with OutOfMemoryError)

The bug was introduced in this commit by @laeubi: #3320.

If you run mvn with -X, you will notice many lines like these:

[DEBUG] C:\Projects\TreeAge\tycho-example\bundles\.polyglot.pom.tycho
[DEBUG] Generate aggregator pom for C:\Projects\TreeAge\tycho-example\bundles\pom.tycho
[DEBUG] Adding module com.vogella.logging.config
[DEBUG] Adding module com.vogella.tycho.p2.ui
[DEBUG] Adding module com.vogella.tycho.platform
[DEBUG] Adding module com.vogella.tycho.platform.linux
[DEBUG] Adding module com.vogella.tycho.plugin1
[DEBUG] Adding module com.vogella.tycho.rcp
[DEBUG] Derived parent for path C:\Projects\TreeAge\tycho-example\bundles is groupId: com.vogella.tycho, artifactId: com.vogella.tycho.root, relativePath: ..\pom.xml
[DEBUG] C:\Projects\TreeAge\tycho-example\bundles\com.vogella.logging.config\.polyglot.META-INF
[DEBUG] C:\Projects\TreeAge\tycho-example\bundles\.polyglot.pom.tycho
[DEBUG] Generate aggregator pom for C:\Projects\TreeAge\tycho-example\bundles\pom.tycho
[DEBUG] Adding module com.vogella.logging.config
[DEBUG] Adding module com.vogella.tycho.p2.ui
[DEBUG] Adding module com.vogella.tycho.platform
[DEBUG] Adding module com.vogella.tycho.platform.linux
[DEBUG] Adding module com.vogella.tycho.plugin1
[DEBUG] Adding module com.vogella.tycho.rcp
[DEBUG] Derived parent for path C:\Projects\TreeAge\tycho-example\bundles\com.vogella.logging.config is groupId: com.vogella.tycho, artifactId: bundles, relativePath: ..\.polyglot.pom.tycho
[DEBUG] C:\Projects\TreeAge\tycho-example\bundles\.polyglot.pom.tycho
[DEBUG] Generate aggregator pom for C:\Projects\TreeAge\tycho-example\bundles\pom.tycho
[DEBUG] Adding module com.vogella.logging.config
[DEBUG] Adding module com.vogella.tycho.p2.ui
[DEBUG] Adding module com.vogella.tycho.platform
[DEBUG] Adding module com.vogella.tycho.platform.linux
[DEBUG] Adding module com.vogella.tycho.plugin1
[DEBUG] Adding module com.vogella.tycho.rcp
[DEBUG] Derived parent for path C:\Projects\TreeAge\tycho-example\bundles\com.vogella.logging.config\META-INF\.. is groupId: com.vogella.tycho, artifactId: bundles, relativePath: ..\.polyglot.pom.tycho
[DEBUG] C:\Projects\TreeAge\tycho-example\bundles\.polyglot.pom.tycho
[DEBUG] Generate aggregator pom for C:\Projects\TreeAge\tycho-example\bundles\pom.tycho
[DEBUG] Adding module com.vogella.logging.config
[DEBUG] Adding module com.vogella.tycho.p2.ui
[DEBUG] Adding module com.vogella.tycho.platform
[DEBUG] Adding module com.vogella.tycho.platform.linux
[DEBUG] Adding module com.vogella.tycho.plugin1
[DEBUG] Adding module com.vogella.tycho.rcp
[DEBUG] Derived parent for path C:\Projects\TreeAge\tycho-example\bundles\com.vogella.logging.config\META-INF\..\.polyglot.pom.tycho\.. is groupId: com.vogella.tycho, artifactId: bundles, relativePath: ..\.polyglot.pom.tycho
[DEBUG] C:\Projects\TreeAge\tycho-example\bundles\.polyglot.pom.tycho
[DEBUG] Generate aggregator pom for C:\Projects\TreeAge\tycho-example\bundles\pom.tycho
[DEBUG] Adding module com.vogella.logging.config
[DEBUG] Adding module com.vogella.tycho.p2.ui
[DEBUG] Adding module com.vogella.tycho.platform
[DEBUG] Adding module com.vogella.tycho.platform.linux
[DEBUG] Adding module com.vogella.tycho.plugin1
[DEBUG] Adding module com.vogella.tycho.rcp
[DEBUG] Derived parent for path C:\Projects\TreeAge\tycho-example\bundles\com.vogella.logging.config\META-INF\..\.polyglot.pom.tycho\..\.polyglot.pom.tycho\.. is groupId: com.vogella.tycho, artifactId: bundles, relativePath: ..\.polyglot.pom.tycho
[DEBUG] C:\Projects\TreeAge\tycho-example\bundles\.polyglot.pom.tycho
[DEBUG] Generate aggregator pom for C:\Projects\TreeAge\tycho-example\bundles\pom.tycho
[DEBUG] Adding module com.vogella.logging.config
[DEBUG] Adding module com.vogella.tycho.p2.ui
[DEBUG] Adding module com.vogella.tycho.platform
[DEBUG] Adding module com.vogella.tycho.platform.linux
[DEBUG] Adding module com.vogella.tycho.plugin1
[DEBUG] Adding module com.vogella.tycho.rcp
[DEBUG] Derived parent for path C:\Projects\TreeAge\tycho-example\bundles\com.vogella.logging.config\META-INF\..\.polyglot.pom.tycho\..\.polyglot.pom.tycho\..\.polyglot.pom.tycho\.. is groupId: com.vogella.tycho, artifactId: bundles, relativePath: ..\.polyglot.pom.tycho
[DEBUG] C:\Projects\TreeAge\tycho-example\bundles\.polyglot.pom.tycho
[DEBUG] Generate aggregator pom for C:\Projects\TreeAge\tycho-example\bundles\pom.tycho
[DEBUG] Adding module com.vogella.logging.config
[DEBUG] Adding module com.vogella.tycho.p2.ui
[DEBUG] Adding module com.vogella.tycho.platform
[DEBUG] Adding module com.vogella.tycho.platform.linux
[DEBUG] Adding module com.vogella.tycho.plugin1
[DEBUG] Adding module com.vogella.tycho.rcp
[DEBUG] Derived parent for path C:\Projects\TreeAge\tycho-example\bundles\com.vogella.logging.config\META-INF\..\.polyglot.pom.tycho\..\.polyglot.pom.tycho\..\.polyglot.pom.tycho\..\.polyglot.pom.tycho\.. is groupId: com.vogella.tycho, artifactId: bundles, relativePath: ..\.polyglot.pom.tycho
[DEBUG] C:\Projects\TreeAge\tycho-example\bundles\.polyglot.pom.tycho
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant