Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PgSubscriberImpl silently does not register exception handler #1404

Open
andreas-eberle opened this issue Feb 2, 2024 · 1 comment
Open
Labels

Comments

@andreas-eberle
Copy link
Contributor

Problem

When you try to regiser an exception handler in PgSubscriberImpl, the handler is never registered. See https://github.com/eclipse-vertx/vertx-sql-client/blob/master/vertx-pg-client/src/main/java/io/vertx/pgclient/impl/pubsub/PgSubscriberImpl.java#L273

There is also no UnsupportedOperationException or any log to make the caller aware that this method is not doing anything right now. This is dangerous, because you think you have registered an exception handler, but in fact you have not and you will never be able to handle exceptions this way.

Version

master

@vietj
Copy link
Member

vietj commented Feb 2, 2024

Actually I think exception handler in this case would not report anything useful, as this is a subscription and the class itself only relay notifications. What do you have in mind ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants