Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAD wavelengths are incorrectly called traces in the overlay #692

Open
Mailaender opened this issue Aug 4, 2021 · 4 comments · May be fixed by #693
Open

DAD wavelengths are incorrectly called traces in the overlay #692

Mailaender opened this issue Aug 4, 2021 · 4 comments · May be fixed by #693

Comments

@Mailaender
Copy link
Contributor

This is somehow in between wrong and a polish problem. DAD wavelengths aren't traces which is confusing wording and the defaults like column bleeding mass traces from GC don't make any sense in LC-DAD scenarios. Someone who uses MS and DAD detectors at the same time might want to save user-defined settings for both without switching all the time in the chromatogram overlay.
@Mailaender Mailaender linked a pull request Aug 4, 2021 that will close this issue
Open
@eselmeister
Copy link
Contributor

Internally, the term "trace" is used as a generic placeholder for m/z values or wavelengths. We should keep it internally as trace. But you're right, the front end labels might make a differentiation.

@Mailaender
Copy link
Contributor Author

Even internally it is called wavelength as far as I see:

chemclipse/chemclipse/plugins/org.eclipse.chemclipse.wsd.model/src/org/eclipse/chemclipse/wsd/model/core/support/IMarkedWavelengths.java

Line 19 in 9921848

public interface IMarkedWavelengths extends IMarkedSignals<IMarkedWavelength> {

@eselmeister
Copy link
Contributor

Yep, correct :-).

The layer on top, especially used in the template processor, uses "trace" as a synonym.
A ticket, which is also in progress, is worth to be mentioned here:
#427

@Mailaender
Copy link
Contributor Author

Trace wavelength is a term in acoustics https://asastandards.org/Terms/trace-wavelength/ but not in analytical chemistry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for named wavelengths in the Chromatogram Overlay Mailaender/chemclipse
2 participants
@eselmeister @Mailaender