Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.eclipse.microprofile.health.HealthCheckResponse leaks #128

Open
rmannibucau opened this issue Jul 9, 2018 · 2 comments
Open

org.eclipse.microprofile.health.HealthCheckResponse leaks #128

rmannibucau opened this issue Jul 9, 2018 · 2 comments
Assignees
Milestone

Comments

@rmannibucau
Copy link

org.eclipse.microprofile.health.HealthCheckResponse uses a static var to store the provider, this doesnt enable to mix impl, it should be looked up each time and a cache is acceptable for perf reason while it ensures it releases the mem on gc (key can be a classloader like).

Alternative is to just let the builder factory be injected and let the impl provide the beam -> no static lookup :)

@antoinesd antoinesd added this to the 2.2 milestone Sep 3, 2019
@antoinesd
Copy link
Contributor

Hi @rmannibucau, could you provide a use case to justify this change that could impact perf ?

@rmannibucau
Copy link
Author

Just take an environment with provider in apps, not in a flat classpath or shared container classloader.

Perf will not be impacted if designed well enough - EE vendors do it since years without issues ;).

@antoinesd antoinesd modified the milestones: 2.2, 3.0 Jan 16, 2020
@antoinesd antoinesd self-assigned this Jul 16, 2020
antoinesd added a commit to antoinesd/microprofile-health that referenced this issue Jul 20, 2020
…sponse leaks

fixes eclipse#128 with multiple providers support addition

Signed-off-by: Antoine Sabot-Durand <antoine@sabot-durand.net>
antoinesd added a commit to antoinesd/microprofile-health that referenced this issue Jul 20, 2020
…sponse leaks

fixes eclipse#128 with multiple providers support addition

Signed-off-by: Antoine Sabot-Durand <antoine@sabot-durand.net>
@antoinesd antoinesd modified the milestones: 3.0, 4.0 Jul 21, 2020
@Emily-Jiang Emily-Jiang modified the milestones: 4.0, Future Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants