Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the behavior when the HealthCheck returns null #213

Open
xstefank opened this issue Oct 21, 2019 · 1 comment
Open

Specify the behavior when the HealthCheck returns null #213

xstefank opened this issue Oct 21, 2019 · 1 comment
Assignees

Comments

@xstefank
Copy link
Member

We should specify the behavior of HealthCheck when null is returned from the call method:

  • should the check be ignored?
  • or should the state be down with some default name?

I am opting to ignore such checks. However, in every case, a TCK to verify the behavior should be added.

Thanks to @rsvoboda for noting this.

@xstefank xstefank self-assigned this Oct 21, 2019
@rsvoboda
Copy link
Contributor

I checked WildFly and Quarkus, they both report DOWN with NPE stacktrace in the log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants