Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion about wellness endpoint #253

Open
antoinesd opened this issue May 19, 2020 · 5 comments
Open

Discussion about wellness endpoint #253

antoinesd opened this issue May 19, 2020 · 5 comments

Comments

@antoinesd
Copy link
Contributor

We planned to introduce a new endpoint /wellness to solve issues like #130 . What are the pros and cons for this introduction?

@antoinesd antoinesd added this to the 3.0 milestone May 19, 2020
@xstefank
Copy link
Member

Just to clarify, it would be /health/wellness right?

@antoinesd
Copy link
Contributor Author

Yes and introduction of @Wellness qualifier

@antoinesd antoinesd modified the milestones: 3.0, 3.1 Jun 10, 2020
@hyperman1
Copy link

My interest in this is for a situation where my application is up, but a required dependency (e.g. upstream web service) is down.

Quarkus on openshift uses live and health to restart a container if they are not healthy. If my application is OK but a dependency is down, automatically restarting my application wont help. Also, I might be partially up but running degraded. Monitoring this so we can warn the owner of the dependency is still relevant.

@xstefank
Copy link
Member

xstefank commented Oct 5, 2020

@hyperman1 hi, thank you for showing interest in this feature. We've already implemented it in our downstream SmallRye project to test out the API before we can include it in the specification (it should be available for you if you are using Quarkus). Would you be able to test it out and give us any feedback, please?

@hyperman1
Copy link

@xstefank That's in fact where I found it, after the quarkus team suggested a custom health group. It does perfectly what I want:

  • Appears in /health (custom health groups don't and @health is deprecated )
  • Does not appear in /health/live or /health/ready.

I get nervous about using @experimental code in production, so I added the comment above in the hope of getting it standardized. Thanks for your extremely fast reaction.

@xstefank xstefank removed this from the 3.1 milestone May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants