Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microprofile-health-81 Ability to execute only some health checks #221

Merged
merged 4 commits into from
Jan 14, 2020

Conversation

antoinesd
Copy link
Contributor

fixes #81
Adding annotations
Amend specification
Add TCK tests

Signed-off-by: Antoine Sabot-Durand antoine@sabot-durand.net

Adding annotations
Amend specification
Add TCK tests

Signed-off-by: Antoine Sabot-Durand <antoine@sabot-durand.net>
Signed-off-by: Antoine Sabot-Durand <antoine@sabot-durand.net>
@xstefank
Copy link
Member

@antoinesd did you verify that the new TCK can pass?

@antoinesd
Copy link
Contributor Author

Not yet. Do you want implement the feature in smallRye to test or do you prefer that I do it ?

@xstefank
Copy link
Member

@antoinesd I implemented this in SmallRye. Everything passes. Thanks.

Copy link
Member

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions. I would also recommend to add something similar like this to the HealthGroup qualifier:

public class HealthGroupLiteral extends AnnotationLiteral<HealthGroup> implements HealthGroup {

        private String groupName;

        public HealthGroupLiteral(String groupName) {
            this.groupName = groupName;
        }

        public static HealthGroupLiteral of(String groupName) {
            return new HealthGroupLiteral(groupName);
        }

        @Override
        public String value() {
            return groupName;
        }
    }

as was originally proposed and it will be repeated in individual implementations. But this can be added in separate PR if you prefer.

spec/src/main/asciidoc/java-api.adoc Outdated Show resolved Hide resolved
spec/src/main/asciidoc/java-api.adoc Outdated Show resolved Hide resolved
antoinesd and others added 2 commits January 13, 2020 11:44
typo

Co-Authored-By: Martin Stefanko <xstefank122@gmail.com>
typo

Co-Authored-By: Martin Stefanko <xstefank122@gmail.com>
@xstefank
Copy link
Member

@antoinesd thanks for the updates. Should we merge this PR and add Literal in a separate one? Or are you still going to include it here?

@antoinesd
Copy link
Contributor Author

I'll create anther PR for literals since it could be useful to have ones for @Liveness @Readiness and @Health

@antoinesd antoinesd merged commit 0e27284 into eclipse:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to execute only some health checks
2 participants