Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Z opcode properties #7066

Open
Spencer-Comin opened this issue Jul 18, 2023 · 3 comments
Open

Correct Z opcode properties #7066

Spencer-Comin opened this issue Jul 18, 2023 · 3 comments

Comments

@Spencer-Comin
Copy link
Contributor

Spencer-Comin commented Jul 18, 2023

In #6447 I corrected some s390 opcode properties. There are likely more incorrect properties.

Correcting the properties will break code that relies on the incorrect properties, e.g. eclipse-openj9/openj9#17804.

This issue is for tracking fixes to the opcode properties and to the code that relies on incorrect properties.

Opcode properties: https://github.com/eclipse/omr/blob/master/compiler/z/codegen/OMRInstOpCodeProperties.hpp

@Spencer-Comin
Copy link
Contributor Author

The different store multiple opcodes have UsesRegRangeForTarget, those should be corrected to UsesRegRangeForSource

@Spencer-Comin
Copy link
Contributor Author

Looking into the properties, there is no UsesRegRangeForSource property. If there is no place where this property is checked where it matters whether the range is a source or target, a more correct name might be just UsesRegRange

@Spencer-Comin
Copy link
Contributor Author

The various cipher message and compute message opcodes need ImplicitlyUsesGPR0 and ImplicitlyUsesGPR1 added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant